chore: split poco into example #2146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
force-pushed
the
ap/poco
branch
3 times, most recently
from
47353ab to
389df3c
Compare
g-awmalik
approved these changes
Oct 24, 2024
| terraform { | ||
| required_providers { | ||
| google = { | ||
| source = "hashicorp/google" |
Contributor
There was a problem hiding this comment.
can we add a version constraint?
Collaborator
Author
There was a problem hiding this comment.
We dropped them from most example to depend on the actual module's version constraint, however we can revisit that decision for the entire repo if there is a need.
| @@ -0,0 +1,45 @@ | |||
| /** | |||
| * Copyright 2021 Google LLC | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2021 Google LLC | |
| * Copyright 2024 Google LLC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Policy Controller into it's own example from Config Sync.